• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ChordGrid & Voltas
#1
I came across an issue with ChordGrids and voltas.
It is common that the the first volta ends with a repeat sign, the second volta ends with a measure bar or a double measure bar.
In case the second volta is on the same line as the first volta, it is not shown and not handled correctly, see attachments.
The ChordPro reference implementation has a similar issue that I reported already in the ChordPro user group
https://groups.io/g/ChordPro/topic/chord.../116866370

   


Attached Files
.pro   ChordGrid_Voltas.pro (Size: 511 bytes / Downloads: 1)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#2
The problem appears to be the :|2 instead of just |2. If you specify just |2, then it works in ChordPro (and I imagine MobileSheets). Is specifying both repeat and volta at the same time actually supported by the specification? I certainly don't allow for that.

Mike
Reply
#3
Sure, I noticed that |2 instead of :|2 would work. But alas it is common that the first volta ends with a repeat mark. The repeat mark is the visual clue for the end of the first volta and corresponds with the beginning repeat mark at the start of the respective part. It is written everywhere that way. This is why I consider that a bug and reported that as a bug also to ChordPro.
       
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#4
So looking at Johan's solution, it seems more like he is just ignoring the repeat, as the image in his response did not show the : before the 2nd volta. I'm assuming that is something you'd actually want to see, so I'd have to add code to specifically handle. It would be great if you can let me know if you agree that the repeat should still be shown with a volta. If so, Johan will also need to modify his code as well.

Mike
Reply
#5
ChordPro originally treated `|2` as a volta and did not understand `:|2`. This is changed now in the latest dev. It now just ignores the colon, so either `|2` and `:2|` will have the same effect. In the grid output, the repeat colon was, and is, always supplied.
Johan
johanvromans.nl — mojore.nl — hetgeluidvanseptember.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 13.0, AirTurn Duo & Digit (Gigs).
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (maint. and backup).
Samsung Galaxy A36 (A366B), Android 15.0.0 (emergency).
Reply
#6
I answered here https://groups.io/g/ChordPro/topic/116866370
The repeat colon is not stupid at all. It is an important visual clue for the end of the first volta and the counterpart of the colon of the begin repeat mark at the beginning of the section. It is common in standard notation, see above.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#7
I've changed ChordPro to add the colon provided it was supplied in the input. So the user has full control over it.
Johan
johanvromans.nl — mojore.nl — hetgeluidvanseptember.nl
Samsung Galaxy Note S7FE (T733) 12.4", Android 13.0, AirTurn Duo & Digit (Gigs).
Samsung Galaxy Note S4 (T830) 10.5", Android 10.0 (maint. and backup).
Samsung Galaxy A36 (A366B), Android 15.0.0 (emergency).
Reply
#8
Here's how it looks now in Johan's fixed development version
   
And another nice discovery: Johan pointed me to right-aligning the second volta with |> , I wasn't aware of that. How great that MobileSheets already supports that. It's not only more convenient and change-friendly than calculating the e.g. {start_of_grid 11+2x4+1} that I used by now. It also avoids different line spaces caused by splitting the grid, see red arrow in Sample 2 in the screenshot
   
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply




Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2026 MyBB Group.