• 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Transposing ABC up or down doesn't work - fixed
#1
I posted a thread about transposing up or down here: 
https://www.zubersoft.com/mobilesheets/f...=transpose
Thank you for trying to implement this, alas it doesn't work in 3.9.37 yet.

Here's an example where both transposing up or down would make sense.
Transposing down from C to G works fine, both on Win11 and in the eink version
       
Transposing up fails, in the eink version the result is one octave too high, on Win11 the screen is empty
       


Attached Files
.pro   AllIDoIsDreamOfYou_ABC.pro (Size: 1.3 KB / Downloads: 1)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#2
Another example. This time transposing down fails.
The original is in G
   
Transposing down to C creates this (same result for eink and Win11)
   
I'd expect that the note g that I marked in green in the 4th measure of the original (in G) would become the C on the first ledger line, as marked in the next-to-last measure of the transposed version. It seems that in this case also transposing down transposes one octave more as it should.

There are songs that are transposed correctly, but I didn't check every combination.


Attached Files
.pro   BadBadLeroyBrown_ABC.pro (Size: 1.84 KB / Downloads: 0)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#3
Another example. This time transposing down fails.
The original is in G
[attachment=4170]
Transposing down to C creates this (same result for eink and Win11)
[attachment=4171]
I'd expect that the note g that I marked in green in the 4th measure of the original (in G) would become the C on the first ledger line, as marked in the next-to-last measure of the transposed version. It seems that in this case also transposing down transposes one octave more as it should.

There are songs that are transposed correctly, but I didn't check every combination.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#4
I implemented the logic we discussed in that previous thread. So I'll have to double check whether what I'm doing is somehow different than what you'd get if you just used the transpose command directly in the ABC content.

Mike
Reply
#5
I think my understanding of your suggestion in the previous thread was incorrect. You said:

for transposing up:

- find the source key in the left half of the list of notes

- find the destination key in the list of notes to the right of the source key

I incorrectly interpreted that as, "find the destination key in the list of notes in the right half".

So I think that's the source of the problem. I think I need to use two capital letters when transposing within the same octave, and if the offset is +12 or more, then I use a capital letter with a lowercase letter.

As far as the rendering issue on Windows, that's occuring because the image generated by the SVG file is so large and does not appear to have anywhere it can be split, so the application is giving up on trying to display it. I'm going to modify this logic to scale the image down to fit the page if needed if it can't be split up easily.

Mike
Reply
#6
We were talking about a list like
C D E F G A B c d e f g a b
It's about finding the NEXT note that matches. Transposing up means searching to the right, transposing down means searching to the left.
For transposing up "All I Do Is Dream Of You" as above from C to G  both 
%%transpose cg 
and
%%transpose CG
work fine
For transposing down only
%%transpose cG
is available

Similarly transposing down "Bad Bad Leroy Brown" down from G to C
works correctly with
%%transpose GC
or
%%transpose gc
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#7
Sharps and flats were missing by now, so I played around a bit in Jef Moines ABC edit 
http://moinejf.free.fr/js/edit-1.xhtml
and extended the list to
C ^C _D D _E E F ^F _G G _A A _B B c ^c _d d _e e f ^f _g g _a a _b b
using the ABC syntax ^ for sharp and _ for flat
D# G# A# seem to be missing, they are replaced by their enharmonics Eb Ab and Bb - this is how the transpose list is already implemented in MobileSheets.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#8
I believe I have it all fixed for the next update now.

Thanks,
Mike
Reply
#9
It would be great if a fix could be available soon. This issue affects a lot of my scores.
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#10
I can send you an updated installer for Android right away, but I'm in the middle of integrating some new changes that I don't want to rush. Windows is obviously more of a pain because the Microsoft Store version of MobileSheets can only be updated through the Microsoft Store. If you want an early installer, just shoot me an email.

Mike
Reply
#11
Fixed.
I re-tested with 3.9.40 on MobileSheets for eink, but the fix has been available already in an earlier version (3.9.38?)
first language: German
Acer A1-830, Android 4.4.2 - HP x2 210 G2 Detachable, Win 10 22H2 - Huawei Media Pad T5, Android 8.0 - Boox Tab Ultra C, Android 11
www.moonlightcrisis.de - www.basdjo.de - www.frankenbaend.de


Reply
#12
Yes, I think it was fixed in 3.9.38 or 3.9.39 (not sure which one off hand).

Mike
Reply




Users browsing this thread:
1 Guest(s)


  Theme © 2014 iAndrew  
Powered By MyBB, © 2002-2026 MyBB Group.